nvaccess / nvda

NVDA, the free and open source Screen Reader for Microsoft Windows
https://www.nvaccess.org/
Other
2.11k stars 637 forks source link

NVDA menu and settings options either missing hotkeys or hotkey not visually underlined. #6741

Closed Qchristensen closed 4 years ago

Qchristensen commented 7 years ago

This issue initially only covered "Report formatting changes after the cursor". For completeness, I have recorded below all NVDA menu and settings options which either do not have a hotkey or for which the hotkey is not underlined.

When you press NVDA+n and bring up the NVDA menu, the hotkey (the letter you can press to activate that item) is underlined on most options. For instance, the "C" in "Configuration profiles" is underlined, indicating you can press C to directly open the configuration profiles screen.

In the NVDA menu and sub-menus, there are several options where the hotkey is not underlined in the menu item and should be.

In the main NVDA menu, "Tools" should have "T" underlined, and "Donate" should have "D" underlined.

In the Tools menu, ONLY "Manage add-ons" has a letter underlined ("a"), so the rest need their hotkey letter underlined.

In the Help menu, the "About" option should have the "A" underlined.

In the "Settings" dialog (looking at the new combined multi-settings dialog), the following options do not have hotkeys underlined:

And for completeness:

ehollig commented 7 years ago

I also notice that the Cell borders combo box does not have a hotkey either. Suggestions on what they should be?

feerrenrut commented 7 years ago

Even though I believe the "report formatting changes after the cursor" option usage is discouraged, for consistency it, and the "cell borders" combo box should have an accelerator. I don't think either of these missing accelerators are particularly important, I'll label this as a P3 Bug and good for new dev.

Next steps:

List out the accelerators that are already used in this dialog, and suggest accelerator keys for these two options.

Code:

Is in source/gui/settingsDialogs.py in class DocumentFormattingDialog Add an ampersand (&) in front of the letter chosen to be an accelerator.