nvaccess / nvda

NVDA, the free and open source Screen Reader for Microsoft Windows
https://www.nvaccess.org/
Other
2.1k stars 634 forks source link

Include braille tables for romanian language in NVDA's braille settings #7847

Closed Adriani90 closed 6 years ago

Adriani90 commented 6 years ago

Steps to reproduce:

  1. Connect a braille display with NVDA and write following: Romanian: Haș
  2. Try to read the words on the Braille Display
  3. Go to the last letter of the romanian word and try to read the single character with eSpeak

Expected behavior:

The letter ș as well as other language specıfıc signs should automatically be properly dısplayed on a braılle dısplay. ș is for example dots 2, 4, 6 (grade 1).

Actual behavior:

On the Braille Display there is a code generated (for romanian letter for example 'x219') instead of displaying the letter itself.

System configuration:

NVDA version: 2017.4

NVDA Installed or portable: Both

Other information:

Windows version: Windows 10 Build 16299.64

Name and version of other software in use when reproducing the issue: All

Other questions:

Does the issue still occur after restarting your PC? yes

Have you tried any other versions of NVDA? Yes, 2017.3, 2017.1

josephsl commented 6 years ago

Hi, let us discuss this on Espeak NG and Libluis mailing lists please. Thanks.

From: Adriani90 [mailto:notifications@github.com] Sent: Monday, December 11, 2017 8:22 AM To: nvaccess/nvda nvda@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [nvaccess/nvda] Add braille output tables for romanian and turkish (#7847)

Steps to reproduce:

  1. Connect a braille display with NVDA and write following: Romanian: Haș
  2. Try to read the words on the Braille Display
  3. Go to the last letter of the romanian word and try to read the single character with eSpeak

Expected behavior:

The letter ș as well as other language specıfıc letters should automatically be properly dısplayed on a braılle dısplay regardless of the language NVDA is set on. ș is for example dots 2, 4, 6 (grade 1). eSpeak should pronounce the sign correctly (tz) when speech language is set on romanian.

Actual behavior:

On the Braille Display there is a code generated (for romanian letter for example 'x219') instead of displaying the letter itself. eSpeak pronounces "letter 219" instead of tz which would be the right pronounciation. The speech language is set on romanian. Romanian signs are not recognized at all, neither when NVDA's language is set on romanian.

System configuration:

NVDA version: 2017.4

NVDA Installed or portable: Both

Other information:

Windows version: Windows 10 Build 16299.64

Name and version of other software in use when reproducing the issue: All

Other questions:

Does the issue still occur after restarting your PC? yes

Have you tried any other versions of NVDA? Yes, 2017.3, 2017.1

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/7847 , or mute the thread https://github.com/notifications/unsubscribe-auth/AHgLkISf7OI18imiOonfpyb8muIcy2Bkks5s_VadgaJpZM4Q9p9L .

Adriani90 commented 6 years ago

Hey Joseph,

looking at the source code, the Romanian table seems to be there. I can find it under dist / louis / tables, as well as in “include / Liblouis” and “source / Louis”. However, in NVDA Braille settings I cannot choose Romanian table.

Do you have any advice how to solve this?

It could be the case for other languages as well.

Best

Adriani

Von: Joseph Lee [mailto:notifications@github.com] Gesendet: Montag, 11. Dezember 2017 17:59 An: nvaccess/nvda nvda@noreply.github.com Cc: Adriani90 adriani.botez@googlemail.com; Author author@noreply.github.com Betreff: Re: [nvaccess/nvda] Add braille tables for romanian language (#7847)

Hi, let us discuss this on Espeak NG and Libluis mailing lists please. Thanks.

From: Adriani90 [mailto:notifications@github.com] Sent: Monday, December 11, 2017 8:22 AM To: nvaccess/nvda <nvda@noreply.github.com mailto:nvda@noreply.github.com > Cc: Subscribed <subscribed@noreply.github.com mailto:subscribed@noreply.github.com > Subject: [nvaccess/nvda] Add braille output tables for romanian and turkish (#7847)

Steps to reproduce:

  1. Connect a braille display with NVDA and write following: Romanian: Haș
  2. Try to read the words on the Braille Display
  3. Go to the last letter of the romanian word and try to read the single character with eSpeak

Expected behavior:

The letter ș as well as other language specıfıc letters should automatically be properly dısplayed on a braılle dısplay regardless of the language NVDA is set on. ș is for example dots 2, 4, 6 (grade 1). eSpeak should pronounce the sign correctly (tz) when speech language is set on romanian.

Actual behavior:

On the Braille Display there is a code generated (for romanian letter for example 'x219') instead of displaying the letter itself. eSpeak pronounces "letter 219" instead of tz which would be the right pronounciation. The speech language is set on romanian. Romanian signs are not recognized at all, neither when NVDA's language is set on romanian.

System configuration:

NVDA version: 2017.4

NVDA Installed or portable: Both

Other information:

Windows version: Windows 10 Build 16299.64

Name and version of other software in use when reproducing the issue: All

Other questions:

Does the issue still occur after restarting your PC? yes

Have you tried any other versions of NVDA? Yes, 2017.3, 2017.1

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/7847 , or mute the thread https://github.com/notifications/unsubscribe-auth/AHgLkISf7OI18imiOonfpyb8muIcy2Bkks5s_VadgaJpZM4Q9p9L .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/7847#issuecomment-350786979 , or mute the thread https://github.com/notifications/unsubscribe-auth/Aaon8daZK_T4C3Bf0aQ6bp491Gn42soxks5s_V9XgaJpZM4Q9p9L . https://github.com/notifications/beacon/Aaon8VAkJtPU3S0rAC_6doAABjU243I8ks5s_V9XgaJpZM4Q9p9L.gif

josephsl commented 6 years ago

Hi, if the Romanian community says the table in Liblouis is ready for the public, that is when I or someone else will add it to the list. CC @LeonardDer

From: Adriani90 [mailto:notifications@github.com] Sent: Monday, December 11, 2017 11:24 AM To: nvaccess/nvda nvda@noreply.github.com Cc: Joseph Lee joseph.lee22590@gmail.com; Comment comment@noreply.github.com Subject: Re: [nvaccess/nvda] Add braille tables for romanian language (#7847)

Hey Joseph,

looking at the source code, the Romanian table seems to be there. I can find it under dist / louis / tables, as well as in “include / Liblouis” and “source / Louis”. However, in NVDA Braille settings I cannot choose Romanian table.

Do you have any advice how to solve this?

It could be the case for other languages as well.

Best

Adriani

Von: Joseph Lee [mailto:notifications@github.com] Gesendet: Montag, 11. Dezember 2017 17:59 An: nvaccess/nvda nvda@noreply.github.com Cc: Adriani90 adriani.botez@googlemail.com; Author author@noreply.github.com Betreff: Re: [nvaccess/nvda] Add braille tables for romanian language (#7847)

Hi, let us discuss this on Espeak NG and Libluis mailing lists please. Thanks.

From: Adriani90 [mailto:notifications@github.com] Sent: Monday, December 11, 2017 8:22 AM To: nvaccess/nvda <nvda@noreply.github.com mailto:nvda@noreply.github.com > Cc: Subscribed <subscribed@noreply.github.com mailto:subscribed@noreply.github.com > Subject: [nvaccess/nvda] Add braille output tables for romanian and turkish (#7847)

Steps to reproduce:

  1. Connect a braille display with NVDA and write following: Romanian: Haș
  2. Try to read the words on the Braille Display
  3. Go to the last letter of the romanian word and try to read the single character with eSpeak

Expected behavior:

The letter ș as well as other language specıfıc letters should automatically be properly dısplayed on a braılle dısplay regardless of the language NVDA is set on. ș is for example dots 2, 4, 6 (grade 1). eSpeak should pronounce the sign correctly (tz) when speech language is set on romanian.

Actual behavior:

On the Braille Display there is a code generated (for romanian letter for example 'x219') instead of displaying the letter itself. eSpeak pronounces "letter 219" instead of tz which would be the right pronounciation. The speech language is set on romanian. Romanian signs are not recognized at all, neither when NVDA's language is set on romanian.

System configuration:

NVDA version: 2017.4

NVDA Installed or portable: Both

Other information:

Windows version: Windows 10 Build 16299.64

Name and version of other software in use when reproducing the issue: All

Other questions:

Does the issue still occur after restarting your PC? yes

Have you tried any other versions of NVDA? Yes, 2017.3, 2017.1

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/7847 , or mute the thread https://github.com/notifications/unsubscribe-auth/AHgLkISf7OI18imiOonfpyb8muIcy2Bkks5s_VadgaJpZM4Q9p9L .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/7847#issuecomment-350786979 , or mute the thread https://github.com/notifications/unsubscribe-auth/Aaon8daZK_T4C3Bf0aQ6bp491Gn42soxks5s_V9XgaJpZM4Q9p9L . https://github.com/notifications/beacon/Aaon8VAkJtPU3S0rAC_6doAABjU243I8ks5s_V9XgaJpZM4Q9p9L.gif

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/7847#issuecomment-350829827 , or mute the thread https://github.com/notifications/unsubscribe-auth/AHgLkLouR3saH0HbMq2Q4KdU43-9lFMuks5s_YFVgaJpZM4Q9p9L .

Adriani90 commented 6 years ago

@josephsl, after Consulting Florian Ionascu, the maintainer of the romanian community, I suggest to implement the romanian language into the Braille Settings.

josephsl commented 6 years ago

CC @LeonardDer, can we do it as part of Liblouis 3.4.1 PR please? Thanks.

From: Adriani90 [mailto:notifications@github.com] Sent: Tuesday, December 12, 2017 6:00 AM To: nvaccess/nvda nvda@noreply.github.com Cc: Joseph Lee joseph.lee22590@gmail.com; Mention mention@noreply.github.com Subject: Re: [nvaccess/nvda] Include braille tables for romanian language in NVDA's braille settings (#7847)

@josephsl https://github.com/josephsl , after Consulting Florian Ionascu, the maintainer of the romanian community, I suggest to implement the romanian language into the Braille Settings.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/7847#issuecomment-351059230 , or mute the thread https://github.com/notifications/unsubscribe-auth/AHgLkHT61EyDVR1WrecEahM__GiqChHDks5s_obugaJpZM4Q9p9L .

LeonarddeR commented 6 years ago

Sure, I'll deal with that.

LeonarddeR commented 6 years ago

@Adriani90: For the speech part of this issue, please consult the Espeak-ng mailing list or file an issue against their repo. I will only deal with braille as part of this issue, as the issue title also says so.

Adriani90 commented 6 years ago

@leonardder, I have edited the issue accordingly. Thank you very much.

Adriani90 commented 6 years ago

I have found a work around for #7848. Maybe you could have a look at that as well.. Thanks.