nvaccess / nvda

NVDA, the free and open source Screen Reader for Microsoft Windows
https://www.nvaccess.org/
Other
2.12k stars 637 forks source link

Error after changing emoji parameters without modify replacement value #8931

Open nvdaes opened 6 years ago

nvdaes commented 6 years ago

Steps to reproduce:

  1. Press NVDA+control+v to verify that Include Consortium Unicode data is checked
  2. Open Symbols dialog
  3. Try to add an existing emoji to search it, pressing the Add button and pasting 😂
  4. Change a parameter other than the replacement, for example punctuation level, and press OK
  5. Press NVDA+control+v and uncheck Include Consortium Unicode data
  6. Try to read 😂 (press NVDA+c if it's copied in clipboard)

Actual behavior:

An error sound is heart and the symbol isn't read.

Expected behavior:

The symbol should be read according with the chosen parameters, even when other emojis are excluded.

System configuration:

NVDA Installed/portable/running from source:

Tested in portable and running from source

NVDA version:

alpha-16235,153b12df

Windows version:

Windows 10 Version 10.0.17134 build 17134

Name and version of other software in use when reproducing the issue:

N/A

Other information about your system:

N/A

Other questions:

Does the issue still occur after restarting your PC?

Yes

Have you tried any other versions of NVDA?

Beta from source

nvdaes commented 6 years ago

nvdaLogAndSymbolsDic.zip

LeonarddeR commented 6 years ago

Confirmed. I'll try to address this.

nvdaes commented 6 years ago

Thanks. Hope to learn seing your approach to fix this. I think about two ways:

  1. Add replacement for every user symbol regardless of the origin (added by users or automatically when including CLR Data). 2 Add a third type of symbols: builtin, user and CLRData, and an additional method to check if a symbol isCLRSymbol, and in that case add the replacement when the symbol is changed from the dialog and emojis are included, to prevent errors if they are excluded. Or even this could be done thinking in the future possibility of excluding and including sets of symbols for different profiles, contained in other dictionaries, naming the method isProfileSymbol or something like that.
nvdaes commented 6 years ago

@Christianlm may be interested in #8932 He's the main author of emoticons add-on. Thanks

Adriani90 commented 5 months ago

@nvdaes, @josephsl is this still an issue in NVDA 2024.2 Beta?

josephsl commented 5 months ago

Hi,

This issue is distantly related to emoji panel - the work I did was letting NVDA navigate emoji panel more easily, not dealing with symbols themselves.

Thanks.

nvdaes commented 5 months ago

@Adriani90 , the described issue persists: the symbol is not read. Thanks.