nvaccess / nvda

NVDA, the free and open source Screen Reader for Microsoft Windows
https://www.nvaccess.org/
Other
2.1k stars 635 forks source link

NVDA should skip disabled add-ons when creating portable or system copies #9020

Open ultrasound1372 opened 5 years ago

ultrasound1372 commented 5 years ago

There is another issue similar to this one open, but it only covers system config and it seems to have not been looked at. Since the disabled add-ons facility was recently added, I figured why not bring this up? I'd like to see this in 2018.4. I, and some other users probably, have some large add-ons such as vocalizer or acapella voices, or other synth drivers and such I do not need on portable copies for school computers. In order to skip copying those now and taking forever to do so, I must cut the add-ons into a temporary storage folder and restart NVDA, create the copy, put them back and restart again. Since we have a facility to disable add-ons I thought why not simply skip copying them if they are disabled? Still requires a restart but you don't have to manually move things around. The same should apply to system config when copying add-ons, I don't need most of my add-ons in system config but I might need a few, like some people need remote, or my primary synth driver, etc.

josephsl commented 5 years ago

Hi, sorry, it won’t make the cut for 2018.4. I’ll take this on but after #6275 is merged into master first. CC @NVDAEs in case she wants to take this on, as checkable list is a good implementation strategy for this. Thanks.

From: Colton Hill notifications@github.com Sent: Wednesday, December 5, 2018 7:22 AM To: nvaccess/nvda nvda@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [nvaccess/nvda] NVDA should skip disabled add-ons when creating portable or system copies (#9020)

There is another issue similar to this one open, but it only covers system config and it seems to have not been looked at. Since the disabled add-ons facility was recently added, I figured why not bring this up? I'd like to see this in 2018.4. I, and some other users probably, have some large add-ons such as vocalizer or acapella voices, or other synth drivers and such I do not need on portable copies for school computers. In order to skip copying those now and taking forever to do so, I must cut the add-ons into a temporary storage folder and restart NVDA, create the copy, put them back and restart again. Since we have a facility to disable add-ons I thought why not simply skip copying them if they are disabled? Still requires a restart but you don't have to manually move things around. The same should apply to system config when copying add-ons, I don't need most of my add-ons in system config but I might need a few, like some people need remote, or my primary synth driver, etc.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/9020 , or mute the thread https://github.com/notifications/unsubscribe-auth/AHgLkJm-j93h1GI7mHhuND6Abec0EnGMks5u1-SsgaJpZM4ZC8yF .

Brian1Gaff commented 5 years ago

Maybe the skip or not should be a setting when you are asked questions when you are about to create a portable version. In some cases you may want them after all. Also has any work been done that might be able to mitigate the issues of reduced functionality on temp copies in windows 10? Brian

bglists@blueyonder.co.uk Sent via blueyonder. Please address personal E-mail to:- briang1@blueyonder.co.uk, putting 'Brian Gaff' in the display name field. ----- Original Message ----- From: "Joseph Lee" notifications@github.com To: "nvaccess/nvda" nvda@noreply.github.com Cc: "Subscribed" subscribed@noreply.github.com Sent: Wednesday, December 05, 2018 3:47 PM Subject: Re: [nvaccess/nvda] NVDA should skip disabled add-ons when creating portable or system copies (#9020)

Hi, sorry, it won’t make the cut for 2018.4. I’ll take this on but after

6275 is merged into master first. CC @NVDAEs in case she wants to take this

on, as checkable list is a good implementation strategy for this. Thanks.

From: Colton Hill notifications@github.com Sent: Wednesday, December 5, 2018 7:22 AM To: nvaccess/nvda nvda@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [nvaccess/nvda] NVDA should skip disabled add-ons when creating portable or system copies (#9020)

There is another issue similar to this one open, but it only covers system config and it seems to have not been looked at. Since the disabled add-ons facility was recently added, I figured why not bring this up? I'd like to see this in 2018.4. I, and some other users probably, have some large add-ons such as vocalizer or acapella voices, or other synth drivers and such I do not need on portable copies for school computers. In order to skip copying those now and taking forever to do so, I must cut the add-ons into a temporary storage folder and restart NVDA, create the copy, put them back and restart again. Since we have a facility to disable add-ons I thought why not simply skip copying them if they are disabled? Still requires a restart but you don't have to manually move things around. The same should apply to system config when copying add-ons, I don't need most of my add-ons in system config but I might need a few, like some people need remote, or my primary synth driver, etc.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/9020 , or mute the thread https://github.com/notifications/unsubscribe-auth/AHgLkJm-j93h1GI7mHhuND6Abec0EnGMks5u1-SsgaJpZM4ZC8yF .

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/nvaccess/nvda/issues/9020#issuecomment-444532861

josephsl commented 5 years ago

Hi, this can be done via checkable list where users can select which add-ons to copy whether or not they are disabled. As for temp copy problem, well, let’s discuss this on a different issue. Thanks,

From: Brian Gaff notifications@github.com Sent: Wednesday, December 5, 2018 8:21 AM To: nvaccess/nvda nvda@noreply.github.com Cc: Joseph Lee joseph.lee22590@gmail.com; Comment comment@noreply.github.com Subject: Re: [nvaccess/nvda] NVDA should skip disabled add-ons when creating portable or system copies (#9020)

Maybe the skip or not should be a setting when you are asked questions when you are about to create a portable version. In some cases you may want them after all. Also has any work been done that might be able to mitigate the issues of reduced functionality on temp copies in windows 10? Brian

bglists@blueyonder.co.uk Sent via blueyonder. Please address personal E-mail to:- briang1@blueyonder.co.uk, putting 'Brian Gaff' in the display name field. ----- Original Message ----- From: "Joseph Lee" notifications@github.com To: "nvaccess/nvda" nvda@noreply.github.com Cc: "Subscribed" subscribed@noreply.github.com Sent: Wednesday, December 05, 2018 3:47 PM Subject: Re: [nvaccess/nvda] NVDA should skip disabled add-ons when creating portable or system copies (#9020)

Hi, sorry, it won’t make the cut for 2018.4. I’ll take this on but after

6275 is merged into master first. CC @NVDAEs in case she wants to take this

on, as checkable list is a good implementation strategy for this. Thanks.

From: Colton Hill notifications@github.com Sent: Wednesday, December 5, 2018 7:22 AM To: nvaccess/nvda nvda@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [nvaccess/nvda] NVDA should skip disabled add-ons when creating portable or system copies (#9020)

There is another issue similar to this one open, but it only covers system config and it seems to have not been looked at. Since the disabled add-ons facility was recently added, I figured why not bring this up? I'd like to see this in 2018.4. I, and some other users probably, have some large add-ons such as vocalizer or acapella voices, or other synth drivers and such I do not need on portable copies for school computers. In order to skip copying those now and taking forever to do so, I must cut the add-ons into a temporary storage folder and restart NVDA, create the copy, put them back and restart again. Since we have a facility to disable add-ons I thought why not simply skip copying them if they are disabled? Still requires a restart but you don't have to manually move things around. The same should apply to system config when copying add-ons, I don't need most of my add-ons in system config but I might need a few, like some people need remote, or my primary synth driver, etc.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/9020 , or mute the thread https://github.com/notifications/unsubscribe-auth/AHgLkJm-j93h1GI7mHhuND6Abec0EnGMks5u1-SsgaJpZM4ZC8yF .

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/nvaccess/nvda/issues/9020#issuecomment-444532861

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/9020#issuecomment-444546126 , or mute the thread https://github.com/notifications/unsubscribe-auth/AHgLkJWP2967UAZic8_HyGNWjuNPNo51ks5u1_J2gaJpZM4ZC8yF .

josephsl commented 5 years ago

Hi,

Ping @NVDAEs as all the necessary things are present.

Thanks.

ultrasound1372 commented 5 years ago

A checkable list would be a good idea for this yes. When you create a system copy and it warns about custom plugins, you can hit copy all, don't copy, or select which to copy. And when creating portable copies, when you check the box a button will appear, choose add-ons... That brings up a dialog with a checkable list where all enabled add-ons are checked by default and disabled ones are unchecked. Then you can modify that as needed, hit OK, other button is cancel, then hit create.

Adriani90 commented 4 months ago

cc: @josephsl, @nvdaes are you still thinking to implement this, now that everything is in place from the technical part?