search

nvaccess / nvda

NVDA, the free and open source Screen Reader for Microsoft Windows
https://www.nvaccess.org/
Other
2.11k stars 637 forks source link

wx.Locale: Aragonese does not have wx.LanguageInfo #9089

Closed josephsl closed 5 years ago

josephsl commented 5 years ago

Hi,

Reported on NvDA translations mailing list and subsequently confirmed: NVDA 2018.4 fails to start properly if UI language is set to Aragonese.

Steps to reproduce:

  1. Install NVDA 2018.4 and current alpha.
  2. From NVDA settings/General, switch language to "Aragonese" and press Enter, and confirm if asked to restart.

Actual behavior:

The following traceback is recorded:

CRITICAL - main (11:26:22.013): core failure Traceback (most recent call last): File "nvda.pyw", line 233, in File "core.pyc", line 390, in main AttributeError: 'NoneType' object has no attribute 'Language'

Expected behavior:

NVDA starts properly with language set to Aragonese.

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

2018.4

Windows version:

Windows 10 Version 1809

Name and version of other software in use when reproducing the issue:

None

Other information about your system:

None

Other questions

Does the issue still occur after restarting your PC?

Yes

Have you tried any other versions of NVDA?

Yes - alpha.16458.

Technical information:

Not all languages come with wx.LanguageInfo, and Aragonese is one of those that isnt' supported by wxPython natively. Thus see if wxLang itself is something and act accordingly.

Thanks.

Adriani90 commented 5 years ago

we have reports from the translator that it works fine now. So I think this issue can be closed and can be reopened if it is being reported again.

ehollig commented 5 years ago

Fixed from #9092. This was not automatically closed because it went into RC for NVDA 2018.4

josephsl commented 5 years ago

Hi,

I'm overriding close status, as this fix is still being tested by some more. I'll close this once 2018.4.1 is released.

Thanks.

Adriani90 commented 5 years ago

@josephsl did you get further test results from users? Are there still issues with Aragonese or other languages?

josephsl commented 5 years ago

Hi, not at the moment.

From: Adriani90 notifications@github.com Sent: Saturday, January 19, 2019 12:02 PM To: nvaccess/nvda nvda@noreply.github.com Cc: Joseph Lee joseph.lee22590@gmail.com; Mention mention@noreply.github.com Subject: Re: [nvaccess/nvda] wx.Locale: Aragonese does not have wx.LanguageInfo (#9089)

@josephsl https://github.com/josephsl did you get further test results from users? Are there still issues with Aragonese or other languages?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/9089#issuecomment-455810766 , or mute the thread https://github.com/notifications/unsubscribe-auth/AHgLkDo5a48zQxf2g-75Ufhg-DpP4Zi5ks5vE3nLgaJpZM4ZY9w_ .

Adriani90 commented 5 years ago

I have tested also on Windows 10 and 8.1 with NVDA 2018.4.1. Everything seems to work properly now. Closing this as works for me since it is also part of NVDA 2018.4.1. We can reopen it if users report this issue again. Thanks.