search

nvaccess / nvda

NVDA, the free and open source Screen Reader for Microsoft Windows
https://www.nvaccess.org/
Other
2.1k stars 634 forks source link

Update Norwegian 8-dot Braille table from no-no-comp8.ctb to no-no-8dot.utb #9170

Closed Qchristensen closed 5 years ago

Qchristensen commented 5 years ago

Is your feature request related to a problem? Please describe.

The current Norwegian 8-dot Braille table in use is an older version which has numerous characters either missing or corrupted.

A new, extended version of the Norwegian 8-dot table is available on LibLouis which addresses these issues.

Describe the solution you'd like

Swap from using no-no-comp8.ctb to no-no-8dot.utb

Describe alternatives you've considered

Additional context

As per conversation on NVDA list at https://nvda.groups.io/g/nvda/message/53392

(Edited to correct table names).

LeonarddeR commented 5 years ago

Hmm, no-no-comp8.ctb and no-no-comp8.ctb are exactly the same table, since they have an identical name 😜

josephsl commented 5 years ago

CC @LeonardDer, @DKager

From: Quentin Christensen notifications@github.com Sent: Thursday, January 17, 2019 10:10 PM To: nvaccess/nvda nvda@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [nvaccess/nvda] Update Norwegian 8-dot Braille table from no-no-comp8.ctb to no-no-comp8.ctb (#9170)

Is your feature request related to a problem? Please describe.

The current Norwegian 8-dot Braille table in use is an older version which has numerous characters either missing or corrupted.

A new, extended version of the Norwegian 8-dot table is available on LibLouis which addresses these issues.

Describe the solution you'd like

Swap from using no-no-comp8.ctb to no-no-comp8.ctb

Describe alternatives you've considered

Additional context

As per conversation on NVDA list at https://nvda.groups.io/g/nvda/message/53392

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/9170 , or mute the thread https://github.com/notifications/unsubscribe-auth/AHgLkAon_qJKsqvkHQXplJTfjJc3WS7eks5vEWUzgaJpZM4aHSae .

larsbjorndal commented 5 years ago

According to the NVDA mailing list thread mentioned, please swap to no-no-8dot.utb

dkager commented 5 years ago

Hah, would be good if @Qchristensen updates the issue title, since it is indeed a bit circular now. :)

LeonarddeR commented 5 years ago

I added the "good for new dev" label. Note that an entry has to be added to brailleTables.RENAMED_TABLES as well.

zstanecic commented 5 years ago

Hi Leonard,

I can do it,

When it’s the dadline?

From: Leonard de Ruijter notifications@github.com Sent: Monday, January 21, 2019 8:05 AM To: nvaccess/nvda nvda@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [nvaccess/nvda] Update Norwegian 8-dot Braille table from no-no-comp8.ctb to no-no-8dot.utb (#9170)

I added the "good for new dev" label. Note that an entry has to be added to brailleTables.RENAMED_TABLES as well.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/9170#issuecomment-455968159 , or mute the thread https://github.com/notifications/unsubscribe-auth/AKohk79jlkYggCgBTp3GLvXGIPedNofBks5vFWaGgaJpZM4aHSae . https://github.com/notifications/beacon/AKohk5mw3MwIH6Kfp8Oco_AuXjlE6Bkaks5vFWaGgaJpZM4aHSae.gif

LeonarddeR commented 5 years ago

@zstanecic: I guess the deadline will be around the merge of #9151. Therefore, a pr like this is likely to be in 2019.1 if filed this week.

zstanecic commented 5 years ago

Hi,

I’ll fill my PR tomorrow after one of my exams on the University Finish.

Thanks,

Zvonimir

From: Leonard de Ruijter notifications@github.com Sent: Monday, January 21, 2019 8:18 AM To: nvaccess/nvda nvda@noreply.github.com Cc: zstanecic zvonimirek222@yandex.com; Mention mention@noreply.github.com Subject: Re: [nvaccess/nvda] Update Norwegian 8-dot Braille table from no-no-comp8.ctb to no-no-8dot.utb (#9170)

@zstanecic https://github.com/zstanecic : I guess the deadline will be around the merge of #9151 https://github.com/nvaccess/nvda/pull/9151 . Therefore, a pr like this is likely to be in 2019.1 if filed this week.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/9170#issuecomment-455970757 , or mute the thread https://github.com/notifications/unsubscribe-auth/AKohkx-VAN2pDYBUfu4xJsnpJ05eQFKcks5vFWmVgaJpZM4aHSae . https://github.com/notifications/beacon/AKohk_pQMyqvGCjDsL4Qf5bhUmm-ox3Jks5vFWmVgaJpZM4aHSae.gif