search

nvaccess / nvda

NVDA, the free and open source Screen Reader for Microsoft Windows
https://www.nvaccess.org/
Other
2.1k stars 635 forks source link

Option to disable the announcement "Copied to clipboard" #9273

Open DrSooom opened 5 years ago

DrSooom commented 5 years ago

Path:

NVDA menu » Preferences » Settings... » Browse Mode

Steps to reproduce:

  1. Select a file or folder in the Windows Explorer, press F2 followed by CTRL+C.
  2. Select this text in a web browser like Firefox and press CTRL+C.

    Actual behaviour:

  3. Nothing is announced.
  4. "Copied to clipboard" is announced via speech and braille (if braille message timeout isn't set to "0").

    Expected behaviour:

    Solution No. 1:

    Add a checkbox called "Report when a selected text has copied to the clipboard in browse mode" in the Browse Mode NVDA Settings. This checkbox is enabled by default (= current behaviour).

    Solution No. 2:

    Add a combobox called "Report when a selected text has copied to the clipboard" to the Browse Mode NVDA Settings with the following values.

    • Never
    • Only in browse mode (virtual documents/web pages) [default value, current behaviour]
    • Only in focus mode (applications)
    • Always

      Reasons:

  5. Inconsistent behaviour which could confuse casual users and beginners.
  6. This "useless" announcement could ride on advanced/power users' nerves, because it always interrupts their workflow.

    System configuration:

    NVDA installed/portable:

    Both

    NVDA version:

    2018.4.1

    Windows version:

    Win7 to Win10-1903

    Name and version of other software in use when reproducing the issue:

    All supported Browsers, Adobe Reader, Foxit Reader etc.

Brian1Gaff commented 5 years ago

I thought nobody had perfected this to work reliably anyway, which is why I use an add on to tell me. It does not mean its copied of course it means that you pressed the right keys. The only time it natively says this is using the screen and global nav keys to copy to the buffer.

lukaszgo1 commented 5 years ago

I definitely agree with @DrSooom we should have a possibility do disable this useless announcementn in browse mode.

netblue44 commented 5 years ago

Lets make shore that this very useful feature is not eliminated altogether

in fact announcing coppied and pasted itomms should be included in NVDA core

On 14/02/2019 05:42 a. m., Łukasz Golonka wrote:

I definitely agree with @DrSooom https://github.com/DrSooom we should have a possibility do disable this useless announcementn in browse mode.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/9273#issuecomment-463597355, or mute the thread https://github.com/notifications/unsubscribe-auth/API6eYwIxlOak5aJ3eXx5SI9PW-sheUJks5vNUu8gaJpZM4a6chk.

LeonarddeR commented 5 years ago

As for item 1, this is a duplicate of #553. Cutting and copying actions could not reliably be tracked.

As for disabling the copy feedback in browse mode, this is not very likely to receive high priority. Giving this a p4

fernando-jose-silva commented 5 years ago

I am in favor of giving the user the choice if they want to hear copied and pasted or even trimmed. I'm giving classes now, and users always get confused if they press the right keys because nvda is muted when copying a file, folder, etc. My students for other times have problems other than vision, such as motor coordination, and intellectual disability.

lukaszgo1 commented 5 years ago

Do you think that NV Access would accept PR adding a possibility to disable this announcement? I am under the impression that for main developer less options the better, but if such feature would be approved I would probably submit a PR for this.

larry801 commented 5 years ago

@fernando-jose-silva You can try clipSepak addon if you want feedback when copying file.

LeonarddeR commented 5 years ago

Do you think that NV Access would accept PR adding a possibility to disable this announcement? I am under the impression that for main developer less options the better, but if such feature would be approved I would probably submit a PR for this.

I could not speak on behalf of NV Access, but I guess such a pr makes sense, as this issue points out that a majority seems to agree that this functionality would be useful.

JulienCochuyt commented 5 years ago

If #9843 is accepted, implementing configurability of control+C announcement in browse mode will be a one-liner (+ GUI). In CursorManager.script_copyToClipboard, line 412, change info.copyToClipboard(notify=True) to something like info.copyToClipboard(notify=config.conf["virtualBuffers"]["notifyOnCopy"])

While I am in favor of a clear message being presented for other copy operations like NVDA+F10*2 or NVDA+T*3, I feel that presenting a message on control+C in browse mode makes beginners feel uncomfortable when no message is presented in other apps, as we cannot reliably present it. It even went as far as a popular addon circumventing this situation by echoing "Copied to clipboard" in every situations, including when there was no selection to copy or control+C was used to cancel an running operation in a console - very bad fix IMHO.

AAClause commented 3 years ago

@JulienCochuyt Do you plan to implement the possibility to disable the announcement soon? The merge of #9843 is a big regression for me and I've already patched the core to prevent the announcement of the text copied to clipboard in browse mode. Indeed when the selection contains a large text and I press CTRL+c, NVDA lags completely. Sometimes pressing Control key doesn't stop speech. Or the synthesizer no longer work during a few seconds, it's very annoying. In general, I don't understand the interest of the announcement of text copied. We already have a command to read any currently selected text (default: NVDA+Shift+upArrow or NVDA+shift+s). This is sufficient IMHO.

feerrenrut commented 3 years ago

Yes, we will accept a PR to allow disabling this announcement, however the difficulty will be working out where the option should be located and the wording of it. A new panel or section may need to be created. Rather than jump to a specific setting for 'copied to clipboard', I'd prefer a generic option for "Speech UI verbosity" with options "low", "normal". In future we could add an option for "custom" that shows a checkable list with all the different messages.

josephsl commented 3 years ago

Hi, I think a new “verbosity” panel would be a good idea to gather together verbosity level and settings like the one being proposed. Thanks.

feerrenrut commented 3 years ago

Or perhaps 'speech presentation': settings related to NVDA's speech UI

Longer term, we hope to also look at customizing the order (perhaps contents) of these UI messages. If we did this, we'd need a mirror panel for 'braille presentation': settings related to NVDA braill UI

josephsl commented 3 years ago

Hi, one possibility is adding a button inside current “speech” and “braille” panels that will open speech/braille UI messages dialog, similar to speech synthesizer and braille display selection mechanism. Thanks.

feerrenrut commented 3 years ago

Maybe, but I think it would be good to separate settings for devices (synth, braille, audio) from settings for UI (speech UI, braille UI)

CyrilleB79 commented 3 years ago

@Andre9642 wrote:

@JulienCochuyt Do you plan to implement the possibility to disable the announcement soon? The merge of #9843 is a big regression for me and I've already patched the core to prevent the announcement of the text copied to clipboard in browse mode. Indeed when the selection contains a large text and I press CTRL+c, NVDA lags completely. Sometimes pressing Control key doesn't stop speech. Or the synthesizer no longer work during a few seconds, it's very annoying.

I have opened #11843 for this regression. Feel free to comment here. Let's keep this issue to talk about the verbosity level.

CyrilleB79 commented 2 weeks ago

I think that UIA notifications in recent MS Office versions just report "Copied", to be checked.

Shortening our "Copied to clipboard" to "Copied" would already make the message shorter for people complaining of this too long message and would make something consistent with other "Copied" messages, even if they are not ours.

What do you think?

Adriani90 commented 2 weeks ago

I agree the message "copied" should suffice for all instances where ctrl+c command is used, also in browse mode.