search

nvanheuverzwijn / monolog-logdna

GNU Lesser General Public License v3.0
21 stars 21 forks source link

Deprecation and expected type warnings #27

Closed MizouziE closed 1 month ago

MizouziE commented 1 month ago

Hi,

While investigating a bug on an application that uses this package I noticed a deprecation warning and a type warning in src/Monolog/Handler/LogdnaHandler.php

    /**
     * @var resource $curl_handle
     */
    private $curl_handle;

Use of this property would expect it to be a CurlHandle.

    public function __construct($ingestion_key, $hostname, $level = \Monolog\Logger::DEBUG, bool $bubble = true)

Monolog\Logger::DEBUG is deprecated and Monolog\Level::Debug should be used in it's place.