nvb-uy / Item_Obliterator

Modpack Utility Mod to remove any items (or just recipes) from the game, with regex and nbt support.
Other
5 stars 5 forks source link

Broken client-only item entity, incompatible with Quark variant selector feature #69

Open copygirl opened 2 months ago

copygirl commented 2 months ago

I have a similar experience as #32, though in a pack I'm building with a bunch of mods. (I have yet to try with fewer mods.) Fake client-side-only entity items are on the ground after breaking a block that is blacklisted.

[12:14:45] [Server thread/WARN] [minecraft/ServerEntity]: Fetching packet for removed entity ItemEntity['Oak Leaf Carpet'/832, l='ServerLevel[New World]', x=-369.71, y=64.34, z=69.67, removed=DISCARDED]

I'm trying to use Quark's experimental variant selector feature to reduce the amount of crafting, inventory management issues, and the number of items showing up in JEI / EMI. Basically this allows me to hold planks, select stairs as a building block, and using up the planks, place stairs instead. It also allows blocks to drop the original block when broken, so when breaking a stair I get planks back. The stair item itself however, should be unobtainable – obliterated, so to say.

Item Obliterator breaks this, too. The broken item entity that spawns client-only is the original block. And I can't pick it up.

I can see three solutions to my issue in particular:

nvb-uy commented 2 months ago

A mod is preventing the sync packet from reaching the client, that has been reported in some 1.19.2 forge modpacks, when an entity is discarded it should automatically be synced with all clients, so this issue is probably caused by some mod breaking that. The most likely culprit is a performance-focused mod.

copygirl commented 2 months ago

It doesn't change the fact that Item Obliterator is not supposed to discard the item in my case.

CapoFantasma97 commented 3 weeks ago

A mod is preventing the sync packet from reaching the client, that has been reported in some 1.19.2 forge modpacks, when an entity is discarded it should automatically be synced with all clients, so this issue is probably caused by some mod breaking that. The most likely culprit is a performance-focused mod.

I confirm it's a problem of Item Obliterator. I made a test instance with just Forge 1.20.1, Item Obliterator 2.3.0 and its library Necromicon 1.6.0 and items set in a blacklist, when broken, drop an unpickable item instead of nothing. Exiting and re-entering the world makes them disappear.

This has been confirmed by #32 as well but ignored.

CapoFantasma97 commented 3 weeks ago

This warning shows up in console, I blacklisted minecraft:torch and when broken it stays on the ground in item form (and cannot be collected):

[15:51:07] [Server thread/WARN] [minecraft/ServerEntity]: Fetching packet for removed entity ItemEntity['Torch'/3, l='ServerLevel[New World]', x=6.62, y=-59.40, z=-0.58, removed=DISCARDED]

I'm not as brilliant as Copygirl, so using KubeJS would be a bit of a pain; I don't even know a lick of Javascript 🐱