nvb-uy / Shield_Overhaul

3 stars 4 forks source link

Incompatibility with Guarding mod. #7

Closed Zano1999 closed 12 months ago

Zano1999 commented 1 year ago

[18:30:14] [main/INFO]: Loading Minecraft 1.19.2 with Fabric Loader 0.14.21 [18:30:14] [ForkJoinPool-1-worker-4/WARN]: The mod "dungeons_arise" contains invalid entries in its mod json:

nvb-uy commented 1 year ago

Fixed in beta 1.0.2

Zano1999 commented 12 months ago

Not fixed for me

Zano1999 commented 12 months ago

[12:32:24] [main/INFO]: Loading Minecraft 1.19.2 with Fabric Loader 0.14.21 [12:32:24] [ForkJoinPool-1-worker-4/WARN]: The mod "dungeons_arise" contains invalid entries in its mod json:

nvb-uy commented 12 months ago

Looks like a conflict with the guarded mod.

nvb-uy commented 12 months ago

Indeed, they seem to have a similar approach to us for the instantaneous blocking, making the mods compatible with each other due to this conflict.

https://github.com/Team-Abode/guarding/blob/1.20.x/src/main/java/com/teamabode/guarding/core/mixin/gameplay/ShieldDelayMixin.java