nvbn / django-bower

Easy way to use bower with your django project
https://django-bower.readthedocs.io/
518 stars 75 forks source link

Fix deadlock in freeze #37

Closed blowerfix closed 9 years ago

blowerfix commented 9 years ago

django-bower uses Popen.wait() but it should use Popen.communicate(). See Python 2 or Python 3. This causes a deadlock when calling bower freeze.

The commit below fixes this issue.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 94.37% when pulling d5f2934a42d32cfc4e097132ade9b2fcd7a776fc on blowerfix:master into 1da6e33cf447b3bd700b3a927235249f46ae694c on nvbn:master.

nvbn commented 9 years ago

Thank you!