nvbn / django-bower

Easy way to use bower with your django project
https://django-bower.readthedocs.io/
518 stars 75 forks source link

Fix management command compatibility with Django 1.8 #39

Closed yprez closed 9 years ago

yprez commented 9 years ago

On Django 1.8 running manage.py bower install returns the following error:

manage.py bower: error: unrecognized arguments: install

This is because Django 1.8 switched to from optparse to argparse for parsing arguments. The proposed fix is described here: https://docs.djangoproject.com/en/1.8/releases/1.8/#management-commands-that-only-accept-positional-arguments

I tested it locally on 1.8 and it fixes the error.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.33%) to 94.04% when pulling cbb31bd9400f75c3b57f7578100aaa8b202bfa81 on yprez:django18 into 642535f2a3dacf4fb3af0df89f011e3227e4e2e0 on nvbn:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.02%) to 94.39% when pulling cbb31bd9400f75c3b57f7578100aaa8b202bfa81 on yprez:django18 into 642535f2a3dacf4fb3af0df89f011e3227e4e2e0 on nvbn:master.

nvbn commented 9 years ago

Thanks!