search

nvbn / django-bower

Easy way to use bower with your django project
https://django-bower.readthedocs.io/
518 stars 75 forks source link

Fix bower management command for Django 1.10 #66

Closed freeyoung closed 7 years ago

PetrDlouhy commented 7 years ago

@freeyoung: Could you please fix the tests (merging with current master might be enough) and add Django 1.10 to the .travis.yml?

freeyoung commented 7 years ago

@PetrDlouhy Sure! I will give it a look today.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 94.524% when pulling 32dd467fee675d927bf07f99565f927160ddef4e on freeyoung:fix-django-1.10 into 4e6fbd03bb9882cd28b125b058cf5f8047696d45 on nvbn:master.

freeyoung commented 7 years ago

@PetrDlouhy I've fixed the tests for django >= 1.8. However for lower versions of django I could not really fix the tests because django 1.8 changed the way to implement custom management commands.

Now that django versions < 1.8 have reached the end of support since December 2015, I propose to remove these versions from .travis.yml. What do you think?

PetrDlouhy commented 7 years ago

I am not maintainer of this repository, so we should ask @nvbn if it is possible to drop the support.

yprez commented 7 years ago

+1, supporting 1.4 is a waste of time imo...

freeyoung commented 7 years ago

Since #71 has been merged, closing.