Fix for Django 1.10 (found by @ivanistheone)

nvbn / django-bower

Easy way to use bower with your django project

https://django-bower.readthedocs.io/

518 stars 75 forks source link

Fix for Django 1.10 (found by @ivanistheone) #69

Closed inducer closed 7 years ago

inducer commented 7 years ago

This PR is @ivanistheone's fix for #68 in pull request form.

coveralls commented 7 years ago

Coverage decreased (-0.5%) to 94.253% when pulling 8a6c0b3f381adaedff6ff7eda5343c88d67298b0 on inducer:master into 4e6fbd03bb9882cd28b125b058cf5f8047696d45 on nvbn:master.

ivanistheone commented 7 years ago

Yeah that was just a hack without reading about the new API. This will need some more work to figure out what changed and also fix other commands like ./manage bower install <pkgname> doesn't work. Right now only ./manage.py bower_install works.

UPDATE: It seems the option_list proprty of BaseCommand was removed in 1.10. The recommended option is to use add_argument for the command, which was introduced in Django 1.8.

Is django-bower supposed to support Django 1.7?

ivanistheone commented 7 years ago

This PR should be closed, https://github.com/nvbn/django-bower/pull/70 will fix this

inducer commented 7 years ago

Nvm. #66, #71 are better.