Changes needed to support Django 1.10 - Githubissues

nvbn / django-bower

Easy way to use bower with your django project

https://django-bower.readthedocs.io/

518 stars 75 forks source link

Changes needed to support Django 1.10 #71

Closed ivanistheone closed 7 years ago

ivanistheone commented 7 years ago

Added Django 1.10 to travis CI and changed travis config so it prints stderr to console and uses tee to send copy to file test_out
added a "fake" option_list attribute to BaseBowerCommand so accesing this attribute in the bower_install command won't break
Added support for the new add_arguemnts api for management commands, it seems the two APIs can coexist fine.

Note this pull requests supersedes #66 #67 by @freeyoung (leaving the old code in place allows us to support Django 1.7 and Django 1.10+)

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 94.618% when pulling 83c4aae9d1499277a67efd2824a8217aaeecf875 on ivanistheone:fix/argparse into 4e6fbd03bb9882cd28b125b058cf5f8047696d45 on nvbn:master.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 94.618% when pulling d0d6d5ec05eeaf55c0e3d52e110266e7aeaff73e on ivanistheone:fix/argparse into 4e6fbd03bb9882cd28b125b058cf5f8047696d45 on nvbn:master.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 94.618% when pulling 9a098ecf8273a385c1582f72d1b045782d62dfa4 on ivanistheone:fix/argparse into 4e6fbd03bb9882cd28b125b058cf5f8047696d45 on nvbn:master.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 94.618% when pulling 0d1e52350ffabf88aadd7eea1e0f406d1a14d984 on ivanistheone:fix/argparse into 4e6fbd03bb9882cd28b125b058cf5f8047696d45 on nvbn:master.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 94.618% when pulling 4380243db766092eacae97094f4350b424c0976d on ivanistheone:fix/argparse into 4e6fbd03bb9882cd28b125b058cf5f8047696d45 on nvbn:master.

yprez commented 7 years ago

@nvbn any chance to get this merged?

freeyoung commented 7 years ago

+1

alxdnlnko commented 7 years ago

+1

Wonskcalb commented 7 years ago

I guess the devs do not want the coverage to decrease

Behoston commented 7 years ago

+1 works for me

yprez commented 7 years ago

I think that optparse can be dropped together with support for Django < 1.8 (the switch to argparse was on 1.8+)...

ivanistheone commented 7 years ago

@yprez the thing is Django 1.7 is a "long term release" and is the version that comes with many distrors (e.g. Debian), so might as well keep the support.

yprez commented 7 years ago

@ivanistheone I'm pretty sure that 1.8 is the LTS, and 1.7 is no longer supported...

Behoston commented 7 years ago

here: https://www.djangoproject.com/s/img/release-roadmap.e844db08610e.png

and if you switch doc to 1.7 at the top of page appear warning about not supported version

ivanistheone commented 7 years ago

Okay. I'll be happy to update the PR if the project maintainers agree with dropping Django 1.4 and 1.7 from the supported list (and the test suite).

onekiloparsec commented 7 years ago

Maintainer seem busier with other important matters... (https://github.com/nvbn/thefuck) Not too happy about that, I'm looking for applying patch during deployment.

nvbn commented 7 years ago

Thanks!

onekiloparsec commented 7 years ago

Thanks to you! My post was a little bit provocative, but I'm happy to leave my patch fade away...

yprez commented 7 years ago

@nvbn thanks! a new release perhaps?

nvbn commented 7 years ago

@yprez released as 5.2.0 😊