Don't rely on $SHELL for detecting shell - Githubissues

nvbn / thefuck

Magnificent app which corrects your previous console command.

MIT License

85.26k stars 3.44k forks source link

Don't rely on $SHELL for detecting shell #738

Open nvbn opened 6 years ago

nvbn commented 6 years ago

When, for example, bash run on top of zsh, $SHELL will be zsh and thefuck will generate wrong alias.

We use $SHELL for performance reason, so for fixing this we need to:

get shell from parent pids in thefuck --alias;
store it in $TF_SHELL;
use $TF_SHELL in fuck.

Related issues: #717 #731 #735

emberquill commented 6 years ago

Was going to report that I'm getting an Unexpected End of File when starting bash from zsh but this ended up being the cause of the issue. eval $(SHELL=bash thefuck--alias) worked.