search

nvcuong / variational-continual-learning

Implementation of the variational continual learning method
Apache License 2.0
187 stars 38 forks source link

Error in mnistGenerator classes #1

Closed wykang closed 6 years ago

wykang commented 6 years ago

Hi, if i am correct, I found a critical problem on your code.

The problem is in the run_split.py -SplitMnistGenerator() In the classes, it vertically stacks two labels of data without data shuffling. As a result, when we call coreset_method() in vcl.py- run_vcl(), it may sample only one label of data if the coreset size is small.

Can you check this problem? Thanks

nvcuong commented 6 years ago

Hi @wykang, there is no problem with that. Both coreset functions in coreset.py do not need the data to be shuffled.

wykang commented 6 years ago

Thanks, I misunderstood the task setting for this algorithm. Now, I got it.