nvdaes / pcKbBrl

Allows braille to be entered via the PC keyboard.
GNU General Public License v2.0
3 stars 1 forks source link

Add ability to config keys to confirm/cancel when typing with one hand #8

Closed nvdaes closed 2 years ago

nvdaes commented 2 years ago

Link to issue number:

None

Summary of the issue:

Sometimes maybe tiring to use the same finger to confirm and cancel when typing with one hand (g,h, t, y), as reported privately.

Description of how this pull request fixes the issue:

nvdaes commented 2 years ago

cc: @CyrilleB79

CyrilleB79 commented 2 years ago

Tested on French Keyboard.

It is working well with any key that does not produce a dot and that issues a character, i.e: ²&é"'(-è_çà)=$ù*<,;:!

Special note: it even works with the "^ key" (located at the right of the P), which is a dead key.

nvdaes commented 2 years ago

@CyrilleB79 , thanks for testing. I was also requested to add ability to send dots typed with one hand every second. I think this may not be always useful, but finally I created it. I'll merge this during this week if possible. Cheers

CyrilleB79 commented 2 years ago

Hi Noelia

I have had a look at the new dev in this PR. I have two remarks:

  1. The documentation is not up-to-date with the new options. They really need to be explained somewhere.

  2. IMO, the automatic validation timeout should be finely configurable, e.g. each 0.1, 0.2 or 0.25 second between 0 and 5 seconds. Indeed, even if almost no one will use this feature, I imagine that each one of the few ones needing it will have very specific needs.

nvdaes commented 2 years ago

Hi Cyrille, I've addressed your comments. Timeout canbe set from 0 to 2000 milliseconds, like the advanced option for cursor in NVDA. Default is 0, that is, confirm keys are needed to send dots. But your idea is great! I've tested this feature with timeout set to 100 ms and seems comfortable. Thanks!

nvdaes commented 2 years ago

Let's merge this now.