search

nvdv / vprof

Visual profiler for Python
BSD 2-Clause "Simplified" License
3.95k stars 154 forks source link

Don't suppress ImportErrors. #47

Closed ryneeverett closed 8 years ago

ryneeverett commented 8 years ago

This is a tool for python programmers. We know what import errors are and they give us some idea what we're doing wrong. Replacing them with a vague error message doesn't help.

nvdv commented 8 years ago

Thanks for bringing this up! Would you mind removing exception handling at __main__.py line 89, since nothing throws this kind of exceptions? Thanks!

ryneeverett commented 8 years ago

@nvdv I don't understand the line you referenced, but I removed the unused exceptions.

nvdv commented 8 years ago

except base_profile.ProfilerRuntimeException... is there to catch all exceptions that are children of ProfilerRuntimeException. Since these exceptions are not raised anymore, this except is not necesary

ryneeverett commented 8 years ago

Gotcha. Just amended the commit.

nvdv commented 8 years ago

Looks great! Thanks!