search

nvdv / vprof

Visual profiler for Python
BSD 2-Clause "Simplified" License
3.95k stars 154 forks source link

Fixing minor quality issues #61

Closed tusharmakkar08 closed 7 years ago

tusharmakkar08 commented 7 years ago

This PR contains minor quality fixes.

nvdv commented 7 years ago

Thanks. Comments are inline.

tusharmakkar08 commented 7 years ago

Hey @nvdv

I have fixed your comments as well as updated eslint and pylint.

Thanks.

nvdv commented 7 years ago

Great, thanks for doing this! Just added a few minor nitpicks.

nvdv commented 7 years ago

Also, could you squash your changes into 1 commit? Thanks!

tusharmakkar08 commented 7 years ago

Hey @nvdv

Due to the merge conflict which happened after my first conflict, rebasing is becoming a mess. I squashed the commits after the merge conflict into one and also used the parenthesis where you mentioned.

Thanks

nvdv commented 7 years ago

OK, thanks for doing this!