Improve heatmap profiler performance 3x

nvdv / vprof

Visual profiler for Python

BSD 2-Clause "Simplified" License

3.95k stars 154 forks source link

Improve heatmap profiler performance 3x #70

Closed jonashaag closed 6 years ago

jonashaag commented 6 years ago

This brought down a 60s-to-profile program down to 20s for me.

nvdv commented 6 years ago

Hi, thanks for PR! It's nice fix, but it seems that call to os.path.abspath is not necessary here and can be done in postprocessing phase (e.g. fill_heatmap) improving overall performance even more.

nvdv commented 6 years ago

@jonashaag Would you mind to change few lines I mentioned? I will merge this PR as soon as possible then.

jonashaag commented 6 years ago

Sorry not using vprof anymore so tbh not interested in working on this atm

nvdv commented 6 years ago

Ok, thanks!