nvdv / vprof

Visual profiler for Python
BSD 2-Clause "Simplified" License
3.95k stars 154 forks source link

Adapt to breaking API changes in pip>=10 #82

Closed hoefling closed 6 years ago

hoefling commented 6 years ago

In the newest release, pip has hidden all of its API in an _internal package, emphasizing that no public API exist in pip (see related issue). Due to that, many packages relying on once public pip API and importing pip.* can't be built anymore, including vprof. This PR proposes using requirements parsing from pkg_resources (part of setuptools package) instead of fixing the imports to pip._internal.download.PipSession and pip._internal.parse_requirements. The advantage of this is that pkg_resources.parse_requirements is part of a public API that is unlikely to change in future.

nvdv commented 6 years ago

Awesome, thanks!