search

nventive / Binding.Intercom

Xamarin Binding for Intercom
Other
13 stars 6 forks source link

Support of Intercom Mobile SDK version 6 #10

Closed kgouraw closed 4 years ago

kgouraw commented 4 years ago

Intercom is deprecating support of SDK 5 or below at end of June this year. Any plan for upgrading it to support new SDK version 6.0 support?

MatFillion commented 4 years ago

Hey @kgouraw 👋

Update is not planned at the moment but we would be happy to accept a pull request !

guillermo-gerard commented 4 years ago

I'm doing a binding to 6.1.0 and resolved all the build problems so far, but now I'm facing a runtime error when trying to use the messenger: I cannot attach any gif/image, the app crashes with:

Java.Lang.NoSuchMethodError
  Message=No virtual method getUri()Landroid/net/Uri; in class Lcom/intercom/input/gallery/GalleryImage; or its super classes
Java.Lang.NoSuchMethodError
  Message=No virtual method withUri(Landroid/net/Uri;)Lcom/intercom/input/gallery/GalleryImage$Builder; in class Lcom/intercom/input/gallery/GalleryImage$Builder; or its super classes

Any clues?

guillermo-gerard commented 4 years ago

I've resolved the problem: it appears that they forgot a commit in the official repository: those two methods from my last comment are not there in the version 2.0.2 of the android gallery composer: image I've found this version (version: unspecified! :D ) https://mvnrepository.com/artifact/com.intercom/android-composer-gallery/unspecified which appears to be newer and it has those methods and works with my code

I have my repo here, just in case anyone need it: https://github.com/guillermo-gerard/Intercom.android.xamarin.binding but I'm thinking of doing a pull request here, in order to have only one place with the binding...

jeremiethibeault commented 4 years ago

Hi @guillermo-gerard we updated the SDK to version 5.1.6 to have Android 9 support. As June 30th is coming, if you want to create a PR that updates it to version 6.* we'll be happy to merge it.

Thanks

guillermo-gerard commented 4 years ago

Hi @jeremiethibeault , I've just post a comment in #12 I think that @HamzaRabah can fix his PR simply by adding the android-composer-gallery-2.0.2.aar I'm mentioning in my comment above, if that doesn't work I can create a PR for you to test and merge, of course, just let me know how it goes.