nverinaud / NVSlideMenuController

A slide menu done right for iOS.
MIT License
175 stars 33 forks source link

Make panGesture a public property #29

Open ajsharp opened 10 years ago

ajsharp commented 10 years ago

It would be nice if panGesture were a public property. Doing so would allow library users to implement a delegate or add targets to the gesture in order to better control it. For example, it's nice to be able to restrict the area that the pan applies to the left portion of the screen. Here's how I do this by implementing one of UIGestureRecognizer delegate methods:

-(BOOL)gestureRecognizerShouldBegin:(UIGestureRecognizer *)gestureRecognizer {
    if ([gestureRecognizer locationInView:gestureRecognizer.view].x < 70.0) {
        return YES;
    }
    return NO;
}
nverinaud commented 10 years ago

Hum...It could be safer to make the setter private aka readonly property in the .h.

ajsharp commented 10 years ago

Yea, good point. So you'd be in favor of making the setter private but the getter public?

nverinaud commented 10 years ago

Yep !

ajsharp commented 10 years ago

@nverinaud Updated this pull request. I think I implemented what we've discussed :wink: