search

nvidia-riva / python-clients

Riva Python client API and CLI utils
MIT License
62 stars 20 forks source link

Added configurable Start and End of Utterance parameters to ASR #80

Closed manishaj-nv closed 2 months ago

manishaj-nv commented 2 months ago

With these changes, clients can now configure end and start of utterance for streaming ASR: The new parameters introduced are: --start-history = int --start-threshold = float --stop-history = int --stop-history-eou = float --stop-threshold = int

rmittal-github commented 2 months ago

@virajkarandikar as well for review

sarane22 commented 2 months ago

Need to update the SHA for https://github.com/nvidia-riva/cpp-clients/blob/main/WORKSPACE#L70
Rest LGTM

rmittal-github commented 2 months ago

Need to update the SHA for https://github.com/nvidia-riva/cpp-clients/blob/main/WORKSPACE#L70 Rest LGTM

yeah, this applies on https://github.com/nvidia-riva/cpp-clients/pull/81, added this comment there

rmittal-github commented 2 months ago

@manishaj-nv for python-clients repo, let's update the SHA for common submodule in this MR

rmittal-github commented 2 months ago

LGTM. Testing with server side is in progress, before we merge