Reimplement 'ifne' as plain shell script

nvie / git-toolbelt

A suite of useful Git commands that aid with scripting or every day command line usage

BSD 3-Clause "New" or "Revised" License

1.25k stars 111 forks source link

Reimplement 'ifne' as plain shell script #34

Closed ernstki closed 4 years ago

ernstki commented 4 years ago

Closes #33.

ernstki commented 4 years ago

Since I'm already in that file, I'm happy to "make the max age configurable," I just don't exactly know what that means. Does that just mean accept a user argument for --since? If that's all, no sweat, I'll do a separate PR for that.

nvie commented 4 years ago

Thank you for this nice little PR that will improve life for Windows users! 🙌

nvie commented 4 years ago

Since I'm already in that file, I'm happy to "make the max age configurable," I just don't exactly know what that means. Does that just mean accept a user argument for --since? If that's all, no sweat, I'll do a separate PR for that.

Yeah, that was the intent. To add a flag for the since flag, and letting that default to '3.weeks.ago', like it is now. If you want to make a PR for that, that's very much appreciated!