search

nviennot / jd-core-java

Java Library for JD-Core, a java decompiler
257 stars 107 forks source link

Bundle the native libraries into the compiled jar #11

Closed lesleh closed 10 years ago

lesleh commented 10 years ago

If done that way, it'd be a lot more portable in terms of both running the jar, as it'd be a single file, and in terms of working on all platforms supported by the JD library itself.

I wrote a patch to support it and the commits are here and here.

Feedback would be much appreciated, thanks.

nviennot commented 10 years ago

I'm not super happy about shipping the .so files, it could be a legal issue if the author is not agreeing to redistributing his binaries

lesleh commented 10 years ago

That wouldn't be a problem if people are downloading and compiling using the source, as it downloads the libraries upon compilation, same as now. It could be an issue if anyone then decided to distribute the jar they compiled, however.

nviennot commented 10 years ago

Merged :)

Thank you :)