nvim-lua / completion-nvim

A async completion framework aims to provide completion to neovim's built in LSP written in Lua
Apache License 2.0
973 stars 78 forks source link

signature_help: merge changes from neovim #360

Closed baltitenger closed 3 years ago

baltitenger commented 3 years ago

This PR updates the autoOpenSignatureHelp function to behave as the builtin signatureHelp handler does (without printing an error message if there's no signature help available).

Note: we will have to merge changes manually if they change in upstream. Ideally, neovim's textDocument/signatureHelp would have a config.silent parameter so we could just use vim.lsp.with([...], { silent = true }) as our handler.

baltitenger commented 3 years ago

Ah oops, just noticed #359