search

nvim-lua / kickstart.nvim

A launch point for your personal nvim configuration
MIT License
16.69k stars 16.61k forks source link

Conform breaking change #987

Open SebasF1349 opened 2 weeks ago

SebasF1349 commented 2 weeks ago

Describe the bug

Conform.nvim has just introduced a breaking change. This is the commit: https://github.com/stevearc/conform.nvim/commit/9228b2ff4efd58b6e081defec643bf887ebadff6

It seems that the only thing kickstart needs to update is the keymap and change

require('conform').format { async = true, lsp_fallback = true }

(https://github.com/nvim-lua/kickstart.nvim/blob/master/init.lua#L635)

with require('conform').format { async = true, lsp_format = "fallback" }

To Reproduce

  1. Just update conform.nvim (doesn't seem to crash kickstart, but probably the fallback won't work).

Desktop

Neovim Version

Nightly

SebasF1349 commented 2 weeks ago

I can make a pr if you want.

rmacklin commented 2 weeks ago

Per https://github.com/stevearc/conform.nvim/pull/456#issuecomment-2178715893 this should be fixed in the latest version - can you confirm?

SebasF1349 commented 2 weeks ago

Will test later on home, but in any case even if the fallback works lsp_fallback has been deprecated and shouldn't be in the config. Change should be made, although it can wait for now just to be backwards compatible with people that hasn't updated yet.