fix: set option to nil if not cached and set by lualine

nvim-lualine / lualine.nvim

A blazing fast and easy to configure neovim statusline plugin written in pure lua.

MIT License

5.72k stars 455 forks source link

fix: set option to nil if not cached and set by lualine #1157

Closed Sam-programs closed 6 months ago

Sam-programs commented 7 months ago

https://github.com/nvim-lualine/lualine.nvim/blob/master/lua/lualine.lua#L567 This line doesn't restore the global 'winbar', because lualine never sets the global 'winbar'. I am not sure why but Goyo's window uses the global winbar option,and lualine not setting global winbar causes the winbar to stay in Goyo. fixes(https://github.com/nvim-lualine/lualine.nvim/issues/1122)

shadmansaleh commented 6 months ago

I don't think if an option isn't set by us we should touch it when it's being restored. This should probably be fixed on Goyo so it properly hides and unhides lualine. We could probably throw a user even when lualine is being hidden or unhidden. But I haven't seen interest in something like that yet. So probably not necessary for now.

Thanks for looking into it.