search

nvim-lualine / lualine.nvim

A blazing fast and easy to configure neovim statusline plugin written in pure lua.
MIT License
6.02k stars 462 forks source link

fix: prioritize user config for extensions on windows #1215

Closed daephx closed 1 month ago

daephx commented 6 months ago

Fixes the second part of: #1213

The same logic fixed in (#1214) is duplicated in the lualine_require module, which appears to be used internally for loading things like extensions.

On windows, user defined extensions that overwrite the builtins similarly cannot be loaded due to the same string matching issue. In addition, the number of queried runtime files is always less-than or equal to 1 due to the all parameter for nvim_get_runtime_file being set to false. Making it impossible to sort the list of files and prioritize ones within the users config path vim.fn.stdpath("config").

daephx commented 1 month ago

Hi @shadmansaleh,

I wanted to follow up on this PR which has been open for a few months. I understand you might be busy, but I’d appreciate it if you could take a look when you have the chance. Thanks!

Upon reflection, the change from vim.startswith to string.match was a bit superfluous, as the main issue is just that the path string needed a trailing separator to prevent bad matches with Windows $ENV:LOCALAPPDATA\nvim-data. But both results are basically the same.

shadmansaleh commented 1 month ago

Thanks again. I didn't see this one.