search

nvim-neo-tree / neo-tree.nvim

Neovim plugin to manage the file system and other tree like structures.
MIT License
3.85k stars 225 forks source link

Commit message on windows is not allowed to contain space. #484

Closed buddhiko1 closed 2 years ago

buddhiko1 commented 2 years ago

One word is ok.

Error when contain space.

e.g "test fterm" Screenshot (14)

cseickel commented 2 years ago

This was originally written with string templates executed by the local shell, but it should be converted to a table (list) of arguments to avoid differences in how strings are quoted or escaped.

I'll do this soon, but I'll have to rely on you to test it and confirm it works because I don't have a windows computer handy right now.

buddhiko1 commented 2 years ago

This was originally written with string templates executed by the local shell, but it should be converted to a table (list) of arguments to avoid differences in how strings are quoted or escaped.

I'll do this soon, but I'll have to rely on you to test it and confirm it works because I don't have a windows computer handy right now.

Ok！ This plugin is of high quality and works well. Thank you for your excellent work！

cseickel commented 2 years ago

This plugin is of high quality and works well. Thank you for your excellent work！

You're very welcome!

I think this is fixed in the main branch right now. Can you give it a try and let me know if it works for you?

buddhiko1 commented 2 years ago

The bug isn't fixed, although i have reinstalled the package.

cseickel commented 2 years ago

The bug isn't fixed, although i have reinstalled the package.

To be clear, you didn't need tlol reinstall, just switch your branch from the recommended v2.x to main and then source the file or restart nvim and run :PackerSync (if you use Packer.)

buddhiko1 commented 2 years ago

Sorry for my carelessness. The bug have fixed after switch branch from v2.x to main. Thanks again.

cseickel commented 2 years ago

Thanks for confirming. This has been released to v2.x, you can switch back to that stable branch now if you want.