search

nvim-neorg / neorg-telescope

Telescope.nvim integration for Neorg
GNU General Public License v3.0
187 stars 24 forks source link

Remove previewer from switch_workspaces #46

Closed alesevero closed 10 months ago

alesevero commented 10 months ago

First of all, thanks for creating this library! Discovered it today and I'm already loving it!

Second, sorry if there is any errors. This is my first ever contribution to a project 😅

Third, I was poking around and I found a switch_workspace function that comes very handy. I haven't found any references to it in the docs so I assume it would be broken 😅

Turns out that when I tested it, my Neovim completely frozen, forcing me to restart it.

I was able to fix the issue by completely removing the previewer from the Telescope filter. After removing it, the command works like a breeze! 🙌🏻

I personally don't find it very useful when switching workspaces, but I also understand that it might be interesting for other people. Therefore I'd like to have your take on it 😃

I thought of making it optional through a config flag, but I haven't understood how to access the configs of a module so I could check it from. If you think that's more reasonable than just removing it and can guide me through how to access configuration, I'd happy to change it!

Thanks!

max397574 commented 10 months ago

Give me a few minutes to try to figure out why it perhaps crashed and then we can likely merge this.

max397574 commented 10 months ago

an explanation could be that you just had so many fiels in the workspace imo it's quite useful to have the preview so I'd prefer to make it configurable and perhaps see how we can optimize the performance (could be that like this the preview function gets called for every workspace so all the norg files you have have to get processed)

So I'd close the pr like this There were no issues with it though 👍 good contribution code-wise