search

nvim-neorg / neorg-telescope

Telescope.nvim integration for Neorg
GNU General Public License v3.0
187 stars 24 forks source link

feat: add configuration for insert_file_link title #62

Closed max397574 closed 4 months ago

max397574 commented 4 months ago

fixes https://github.com/nvim-neorg/neorg-telescope/issues/59 supersedes https://github.com/nvim-neorg/neorg-telescope/pull/60 could you test this @f4z3r @benlubas

f4z3r commented 4 months ago

@max397574 ah nice modules.get_module_config() makes for a much nicer implementation indeed. I was not aware of that function sorry.

I tested it and it works great!

max397574 commented 4 months ago

so this works for you and would close your pr and the issue right? I also tried the config option and it felt faster even though the lag was nowhere as bad for me as described in the issue because I don't have such a big workspace

f4z3r commented 4 months ago

so this works for you and would close your pr and the issue right? I also tried the config option and it felt faster even though the lag was nowhere as bad for me as described in the issue because I don't have such a big workspace

Yes, IMO it would close my PR and issue.

max397574 commented 4 months ago

yes because it can return nil so it's needed to make lua-language-server happy and I do check for nil

f4z3r commented 4 months ago

yes because it can return nil so it's needed to make lua-language-server happy and I do check for nil

Hahahah I am aware of that. I meant why use the union style annotations rather than the question mark style for potentially nil values.