nvim-neorg / neorg-telescope

Telescope.nvim integration for Neorg
GNU General Public License v3.0
187 stars 24 forks source link

feat: added icons and preview to `insert_file_link` and `insert_link` #70

Closed drearondov closed 2 months ago

drearondov commented 2 months ago

Hello, I've added icons and preview window to the insert_file_link and insert_link functions.

image

To get syntax highlighting, I added this to my Neovim config.

require("plenary.filetype").add_table {
  extension = {
    ["norg"] = "norg",
  },
}
max397574 commented 2 months ago

Tbh I don't see why we should add an icon there in front of the paths (and just generally a bookmark icon there doesn't make sense for me)

I don't think the plenary thing should be necessary. Norg filetype is builtin now in core. If telescope doesn't recognize it you should open an issue there or in plenary repo.

max397574 commented 2 months ago

Also please change the commit message to not include an emoji Something like the pr title which I changed

drearondov commented 2 months ago

Tbh I don't see why we should add an icon there in front of the paths (and just generally a bookmark icon there doesn't make sense for me)

I don't think the plenary thing should be necessary. Norg filetype is builtin now in core. If telescope doesn't recognize it you should open an issue there or in plenary repo.

I though about adding the icons, because all of the other pickers have them (like the telescope built-ins), but really it's just a cosmetic thing.

About the plenary thing, I added it in the PR because I found the "-- I couldn't get syntax highlight to work with this :(" comment in the file, and since I was making changes to the previewer I didn't want them to get dismissed because of a possible syntax highlighting issue.

max397574 commented 2 months ago

well for builtin picker it might make sense to add icons because they represent the filetypes also devicons is an optional dependency there Here you just hardcode an icon which doesn't add additional value

drearondov commented 2 months ago

I've applied the requested changes

Thanks for the patience and I apologise if anything I said was rude or pretentious in any way.