search

nvim-neorocks / nurr

A repository for hosting auto-generated Neovim plugins and tree-sitter parsers for Luarocks.
MIT License
28 stars 3 forks source link

telescope-fzf-native.nvim needs to run `make` #18

Open xfactor2000 opened 1 month ago

xfactor2000 commented 1 month ago

Hello. I was trying to install https://github.com/nvim-telescope/telescope-fzf-native.nvim but hit a dead-end with make command which needs to run first time plugin is initiated. For example, with lazy.nvim it's simple:

{ 'nvim-telescope/telescope-fzf-native.nvim', build = 'make' }

I wasn't able to configure it for rocks.nvim though.

Appreciate your help and keep up the great work!

mrcjkb commented 1 month ago

Hey 👋

If the plugin is packaged for luarocks, any build steps should be included in the rockspec and you needn't worry about it. Luarocks will take care of building it automatically. If it isn't working, then there is an issue with the rockspec.

(cc @teto, https://github.com/nvim-neorocks/nurr/pull/11).

As a workaround, if it isn't working, it can be installed using rocks-git.nvim, which has a build option.

mrcjkb commented 1 month ago

Transferring this issue to NURR. We either need to add support for custom rockspecs/rockspec templates, or we should PR telescope-fzf-native.nvim.

mrcjkb commented 1 month ago

question @teto: Had you tested this? Does luarocks compile the C sources automatically, using the builtin build backend, or do we need to change it to use the make build backend?

xfactor2000 commented 1 month ago

Hey 👋

If the plugin is packaged for luarocks, any build steps should be included in the rockspec and you needn't worry about it. Luarocks will take care of building it automatically. If it isn't working, then there is an issue with the rockspec.

(cc @teto, #11).

As a workaround, if it isn't working, it can be installed using rocks-git.nvim, which has a build option.

Thank you, will try this. Another workaround is to use fzf-lua. Cheers!

xfactor2000 commented 1 month ago

Hey 👋 If the plugin is packaged for luarocks, any build steps should be included in the rockspec and you needn't worry about it. Luarocks will take care of building it automatically. If it isn't working, then there is an issue with the rockspec. (cc @teto, #11). As a workaround, if it isn't working, it can be installed using rocks-git.nvim, which has a build option.

Thank you, will try this. Another workaround is to use fzf-lua. Cheers!

Can confirm it works with rocks-git.nvim

mrcjkb commented 1 month ago

I just remembered I have an open PR for this:

mrcjkb commented 1 month ago

Removing telescope-fzf-native from luarocks/NURR, as it is broken. I will await a response to the PR before I add it again.