Closed bottd closed 3 weeks ago
Does this PR follow the Contribution Guidelines? Following is a partial checklist:
Proper conventional commit scoping:
For example, fix(installer): some installer bugfix
[ ] Pull request title has the appropriate conventional commit prefix.
If applicable:
Hi @mrcjkb I updated this now, this implementation uses a field named setup
. Note a breaking change here is moving config = "path.to.config"
to be under the setup
field, resulting in config
being for tables only. Due to this change being breaking I am ok with pulling it out and making this work with either field being a string. In the long term I think it would be best for only one of these fields to point to a module path.
I also included a warning for the invalid config you pointed out, where setup = false
and config
has been set.
Closing in favour of #66.
Thanks for the PR :pray:
This adds the ability to opt out of
auto_setup
for specific plugins. I took the name from #9 but added underscore so it matchesauto_setup
field. I added some text to the README to mention it, but I feel like it could use some more documentation/a better example plugin to callno_setup
on. Excited to hear your thoughts!I also looked to see if I need to declare the type or shape of options provided by
rocks-config.nvim
and did not find it. If this is something that needs to be done somewhere I am happy to add it.