fix: remove local rock outside of sync query_installed_rocks callback

nvim-neorocks / rocks-dev.nvim

A swiss-army knife for testing and developing rocks.nvim modules.

GNU General Public License v3.0

15 stars 3 forks source link

fix: remove local rock outside of sync query_installed_rocks callback #21

Closed bottd closed 4 months ago

bottd commented 4 months ago

This is a fix for the 2nd error in https://github.com/nvim-neorocks/rocks-dev.nvim/issues/16

I believe the error about calling from a sync context is due to operations.remove being called inside of the query_installed_rocks callback. By calling from outside of this context the removal works as expected.

github-actions[bot] commented 4 months ago

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

For example, fix(installer): some installer bugfix
[ ] Pull request title has the appropriate conventional commit prefix.

If applicable:

[ ] Tested
- [ ] Tests have been added.
- [ ] Tested manually (steps in PR description).
[ ] Updated documentation.