Closed benlubas closed 3 months ago
Does this PR follow the Contribution Guidelines? Following is a partial checklist:
Proper conventional commit scoping:
For example, fix(installer): some installer bugfix
[ ] Pull request title has the appropriate conventional commit prefix.
If applicable:
Is there a way to further isolate the tests? neovim globals seem to persist between tests so I had to explicitly unset it after each test for it to work.
I think this is only possible if you use GNU parallel
or fd -x
to run each test file in parallel. But then you need to make sure the environments are isolated.
Tested manually. I am unable to test manually, the plugin doesn't seem to work when installed from git
Strange :thinking: Are you using rocks-git.nvim? Anyways, the automated test looks good to me.
Done, also added a note about dir
having priority over dev = true
I'm pretty sure that this works. but
rocks-dev.nvim
doesn't seem to work if it's installed withrocks-git.nvim
so I don't have a good way to test until it's published I don't think.Is there a way to further isolate the tests? neovim globals seem to persist between tests so I had to explicitly unset it after each test for it to work.