feat(installation): bootstrapping support

nvim-neorocks / rocks.nvim

Neovim plugin management inspired by Cargo, powered by luarocks

GNU General Public License v3.0

378 stars 6 forks source link

feat(installation): bootstrapping support #281

Closed vhyrro closed 3 weeks ago

vhyrro commented 3 weeks ago

Apart from an installer one may want to install rocks.nvim through a bootstrapping script.

This PR adds support for such a bootstrapping script for installing rocks.nvim whenever it can't be found.

Notes:

[x] We may want to mention that order matters in the bootstrapping script. I.e. - the rtp should be modified before the existence of rocks.nvim is checked for.
[x] The readme shouldn't point to the pull request branch, that was just for testing :sweat_smile:

github-actions[bot] commented 3 weeks ago

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

For example, fix(installer): some installer bugfix
[x] Pull request title has the appropriate conventional commit prefix.

If applicable:

[x] Tested
- [ ] Tests have been added.
- [x] Tested manually (steps in PR description).
[x] Updated documentation.

mrcjkb commented 3 weeks ago

suggestion(non-blocking): It would be nice to have an integration test for this (not using nix - I don't think it would be possible to sandbox it). It could be a matrix over all platforms, replacing the existing Windows test.

init.lua with the bootstrapping logic
- Maybe a CI action that injects the init.lua into the readme so we have a single source of truth? Or the other way around?
Start neovim
Try to run a :Rocks command

Feel free to create an issue from this comment if you don't want to do it with this PR.

vhyrro commented 3 weeks ago

An integration test would be very nice. I'd keep that in a separate PR, will make an issue for it

vhyrro commented 3 weeks ago

@NTBBloodbath changes have been addressed, let me know if there's anything else to do. In the meantime I'll work on addressing the first TODO in the PR message :)