search

nvim-neotest / neotest-go

MIT License
124 stars 43 forks source link

Revert "feat: luarocks support" #90

Closed sergii4 closed 2 months ago

sergii4 commented 2 months ago

Reverts nvim-neotest/neotest-go#88

Failed run.

@mrcjkb could please take a look?

mrcjkb commented 2 months ago

Hey :wave:

It's failing because the release-please workflow needs a github token. I had set token: ${{ secrets.GH_TOKEN_FOR_UPDATES }}.

You can follow this guide to generate a token and add it to this repo's secrets, it should fix the error (note that the guide names it PAT instead of GH_TOKEN_FOR_UPDATES).

sergii4 commented 2 months ago

@mrcjkb what about

Unexpected input(s) 'package-name', valid inputs are ['token', 'release-type',
mrcjkb commented 2 months ago

@mrcjkb what about

Unexpected input(s) 'package-name', valid inputs are ['token', 'release-type',

:thinking: I suppose the package-name input is no longer used and can be removed. But it's just a warning, it won't lead to a failure.

Edit: Yep, the package-name input was moved to a manifest file: https://github.com/google-github-actions/release-please-action?tab=readme-ov-file#package-options But I don't think it's needed for luarocks packages.

sergii4 commented 2 months ago

@mrcjkb I don't have an access to the repo settings @akinsho @rcarriga could you please take a look?

sergii4 commented 2 months ago

I will revert it so far

rcarriga commented 2 months ago

Just did this recently so copied what I did (I was using semantic-release in other repos) and then added a LUAROCKS_API_KEY for the neotest luarocks account https://github.com/nvim-neotest/neotest-go/pull/92

@sergii4 since you're maintainer of this repo, if you'd prefer a different approach, feel free to alter. The secret will be available for you to use anyway

sergii4 commented 2 months ago

@rcarriga not sure if I have any option since I don't have access to the Settings section of the repo. Not sure how it's usually being granted

rcarriga commented 2 months ago

Sorry I mean you can edit the workflow if you'd like, the secret LUAROCKS_API_KEY will be available to use, you don't need to edit the secrets.

If you don't have any particular opinion on it, you can also just merge. I don't think there's any meaningful difference between semantic-release and release-please

rcarriga commented 2 months ago

Also looks like the tests are failing which will block releases with the current setup FYI