nvim-neotest / nvim-nio

A library for asynchronous IO in Neovim
MIT License
305 stars 9 forks source link

get_active_clients is deprecated in nvim 0.10 #19

Closed seocamo closed 5 months ago

seocamo commented 5 months ago

NeoVim Version NVIM v0.11.0-dev-45+g879d17ea8 Build type: RelWithDebInfo LuaJIT 2.1.1713484068 Run "nvim -V1 -v" for more info

Describe the bug get_activeclients is deprecated in version 0.10 and will be remove in 0.12, so it call notify and make popups. the problem is on line 35 `for , client in pairs(vim.lsp.get_active_clients(filters)) do` in lsp.lua

have to fix replace vim.lsp.get_active_clients with (vim.lsp.get_clients or vim.lsp.get_active_clients) with the () is important as it will pick the new get_clients if found ellers fall back on the old get_active_clients for old versions.

so the line should look like this for _, client in pairs((vim.lsp.get_clients or vim.lsp.get_active_clients)(filters)) do

thanks for a great plugin.