Closed TheTaoOfSu closed 4 months ago
Thank you for this amazing job. I will review and merge it this evening.
I took a pass over every thing rather quickly, I did not see any special issue. I also pulled your changes and did some basic testing and did not encounter any problem. As this is still not a merge to main anyway, it is ok to merge and build on this basis. Once again, thank you very much for your involvement.
On the subject of testing, while I have done some basic testing myself, I do not have a compatible vault of my own to use for testing. Since no functionality has been intentionally changed, there theoretically should be no impact, but I am not equipped to test in more depth.
This is has indeed been a problem for quite some time. I am waiting for @renerocksai to move this project to a proper organization so we can setup a repository with a few dummy notes, tags, etc and create a standardized test environment like that. This will also simplify issue/bug reports in the future.
I am terribly sorry for being so unavailable and becoming the bottleneck. I'll try to move to org now, @lambtho12!
Proposed change
This pull request attempts to merge the main branch into the refact branch. The goal is to import all new functionality from more recent changes to main while maintaining the newer names and overall structure of refact.
The following files received manual changes:
All other changes were performed automatically by git when the merge was initially attempted. I have reviewed these changes, and they seem reasonable, but a more knowledgeable eye may want to glance over them still.
Type of change
Additional information
This PR does not seem to have a corresponding issue. However, discussion #239 is relevant.
Checklist
.stylua.toml
file is provided).luacheckrc
file is provided)README.md
has been updated according to this change.doc/telekasten.txt
helpfile has been updated according to this change.On the subject of testing, while I have done some basic testing myself, I do not have a compatible vault of my own to use for testing. Since no functionality has been intentionally changed, there theoretically should be no impact, but I am not equipped to test in more depth.
As no functionality has been added, no changes have been made to README or to the doc file.