nvim-telekasten / telekasten.nvim

A Neovim (lua) plugin for working with a markdown zettelkasten / wiki and mixing it with a journal, based on telescope.nvim
MIT License
1.42k stars 91 forks source link

docs: started typing _setup, Setup, and cfg #333

Closed ujisati closed 5 months ago

ujisati commented 5 months ago

Proposed change

Lua language server is really good at type checking, so I'm adding some type hints. I like types. You can agree or disagree on that one.

Type of change

Additional information

Checklist

lambtho12 commented 5 months ago

Thank you very much for improving the doc. It's great to see people starting to contribute a bit! The issue was addressed in #332 that I just merged. Next time I will try to merge faster to avoid duplicate fixes.

Feel free to work with @TheTaoOfSu to improve the documentation so they can focus on more heavy lifting in the refactoring maybe?

TheTaoOfSu commented 5 months ago

I've done what I can to implement the LDoc/LuaDoc style that you used in your recent PR, but I've only applied it to comments I personally wrote when I started the refactor on the functions I've personally spent some time examining. These are primarily functions that are in lua/telekasten.lua in main, though many have been relocated in the refact branch, and it's pretty much exclusively focused on a basic overview of the function and specifying type and descriptions for all parameters and return values. Comments and documentation are definitely something I'd like to see improved, but it's a pretty low priority for me at the moment compared to the refactor itself. If you'd like to help in this department, I would definitely welcome and appreciate the effort.