search

nvim-telescope / telescope-frecency.nvim

A telescope.nvim extension that offers intelligent prioritization when selecting files from your editing history.
MIT License
697 stars 35 forks source link

Fuzzy matching is worse than normal telescope #163

Closed sahinakkaya closed 6 months ago

sahinakkaya commented 6 months ago

~I don't know if this is expected behaviour~ (yes, it was. :FrecencyValidate! to fix) ~but when I run this extension, it shows me deleted files~. And also the sorting seems to not working. See the screenshot attached:

20240105_14h10m59s_grim

~As you can see from the right side of the terminal window, there is only 4 files in the current working directory. style/ directory is deleted. But it still shows up in Telescope frecency workspace=CWD window.~

Also, config.js is not first item on the list even though I almost typed the whole file name.

Edit: I was able to fix showing deleted files issue by using :FrecencyValidate!. But it is still sorting files awkwardly.

delphinus commented 6 months ago

You cannot use fuzzy-match for this picker. When you use it, telescope sorts the results again without frecency's scores ;( See https://github.com/nvim-telescope/telescope-frecency.nvim/pull/1#issuecomment-764586539

In default, this picker always uses sorters.get_substr_matcher() (see here). How do you use fuzzy-match with this picker? I want to see your setup (init.lua).

sahinakkaya commented 6 months ago

How do you use fuzzy-match with this picker? I want to see your setup (init.lua).

I think you misunderstood me. I couldn't use fuzzy match and that was my request in the issue. But I got your point now. If I understand you correctly, sorting the result is handed of to telescope and you can't use a custom sorter for this plugin. If this is the case, there is nothing can be done here to fix it.

sahinakkaya commented 6 months ago

And I also understand why you got me wrong. I misused the term "fuzzy matching" in the title while meaning telescope search results. Since telescope runs fuzzy-matcher on most of its operations, I called it normal telescope :D

delphinus commented 6 months ago

Ah I see. I listened to you and thought it is good if such sorter, that uses fuzzy-matching and frecency scores, exists. I issued that to #165. I try it later.