fix: fetch lsp workspaces without triggering tag completion

nvim-telescope / telescope-frecency.nvim

A telescope.nvim extension that offers intelligent prioritization when selecting files from your editing history.

MIT License

777 stars 37 forks source link

fix: fetch lsp workspaces without triggering tag completion #69

Closed MunifTanjim closed 2 years ago

MunifTanjim commented 2 years ago

Currently LSP workspaces are only fetched when user triggers :<Tab> completion. So, if you set your default_workspace to LSP, it doesn't work.

With the changes of this PR, LSP workspaces will be fetched as soon as LSP is attached to a buffer, so it'll work after that.

Conni2461 commented 2 years ago

thanks :)

Conni2461 commented 2 years ago

LspAttach is a nightly feature so it breaks 0.7.0. Because telescope.nvim has 0.7.0 support we are not doing this. I am fine with merging a different solution that isn't dependent on LspAttach. Sorry i had to revert. Still thanks for the PR

MunifTanjim commented 2 years ago

@Conni2461, can we feature detect it? vim.fn.exists('##LspAttach') == 1 should work, right?

Conni2461 commented 2 years ago

do you have a solutions that works the same for 0.7.x and for nightly, otherwise, yeah why not just open a new PR