Closed Conni2461 closed 3 years ago
make
works well now, make clean
throws error(regular windows stuff), I had to manually remove build
folder.
rm -rf build
process_begin: CreateProcess(NULL, rm -rf build, ...) failed.
make (e=2): The system cannot find the file specified.
make: *** [clean] Error 2
Thanks for testing. Wanna try and pull again?
I don't think i need to support everything but i think supporting make
and make clean
on windows makes sense :)
Latest commit 23a2f10 works as expected on OpenBSD. Thanks for checking in.
also, the -p
folder is still being created, so when you make
again, it throws an error that it was already created, and then it doesn't make
at all.
So I'd suggest to remove the -p
on the make
command(on windows of course), or to add it on the RM
command like rmdir /q /s -p build
Thank you for supporting windows platform 👍
I'll remove the -p
on windows and i add a minus in front of mkdir so it doesn't throw an error if it fails (build dir already exist). Give me 5min :)
Everything works OK!
So we can merge it. Thanks for testing :)
Close #24
@luisiacc Can you try if this works now? Out of the box. So checkout branch and
make clean && make
@ryanreno Can you check if OpenBSD still works after that. I need to force
CC=gcc
for windows. windows doesn't havecc
. I only set it if the OS is windows but i still wanted to ask, if you can test it. Thanks :)