search

nvim-telescope / telescope-fzf-native.nvim

FZF sorter for telescope written in c
1.36k stars 45 forks source link

Inconsistent syntax with original fzf #52

Open simonmandlik opened 2 years ago

simonmandlik commented 2 years ago

Combination of NOT (!) operator and OR (|) works differently than in vanilla fzf.

For example (on this repo with default telescope + fzf-native config):

image

whereas command line fzf gives me

image
Conni2461 commented 2 years ago

I don't guarantee completeness: https://github.com/nvim-telescope/telescope-fzf-native.nvim#disclaimer because its not a 1:1 copy of the go code.

But this looks like a bug in my prompt parsing. I'll look into it if i find the time

Conni2461 commented 2 years ago

finally found some time fixing this issue: https://github.com/nvim-telescope/telescope-fzf-native.nvim/pull/56

Could you try out this PR? dont forget to rerun make :) Thanks

Also please mention if you found any regressions, the tests dont indicate any but i am not sure right now. I havent looked at this code in a while

Conni2461 commented 2 years ago

!a | !b is also borked

simonmandlik commented 2 years ago

Yes, there are still some problems. !a | !b doesn't work for me either