search

nvim-telescope / telescope-fzf-native.nvim

FZF sorter for telescope written in c
1.36k stars 45 forks source link

Cont. CMake Windows Build Support #68

Closed nyxkrage closed 2 years ago

nyxkrage commented 2 years ago

This is a continuation on #50 which has not received any updates after the initial feedback on the CMake commit.

This keeps the root Makefile for compatibility

Conni2461 commented 2 years ago

Nice thank you very much :) We should probably add docs / a windows section in the readme, after that this is good to go, i think

nyxkrage commented 2 years ago

Yeah, I'm thinking adding paragraph above the packer and plug snippets explaining that CMake and the C++ build tools are required on Windows, and CMake, make, and either GCC or Clang is required for *nix systems. replace the snippets with the appropriate cmake commands (Both Packer and Plug support chaining commands with && btw) and then add a paragraph after explaining that the old make way still works and that you just replace the run/do command with make.

However if you would rather want to keep the old install instructions and just add a Windows section and then mention in there that it works on all platforms, I could do that too

Conni2461 commented 2 years ago

We can update all install documentation and explain that both works and will be supported in the future. Because i am not planing to drop makefile.

And then add a sentence that cmake is suggested for windows systems