Closed andrew-pa closed 2 years ago
Thanks :) I think its easier to change the resulting extension to .so
otherwise we need to adjust the Makefile for macos and changes in lua
Thanks :) I think its easier to change the resulting extension to
.so
otherwise we need to adjust the Makefile for macos and changes in lua
Yeah makes sense. Thank you! This extension is a great improvement for Telescope.
I tried to install on MacOS using the provided shell snippet in the README, but it seems by default CMake builds the library as
libfzf.dylib
, which of course then doesn't load because it expectslibfzf.so
:The provided Makefile seems to work fine, and it is easy enough to instruct CMake to build a .so instead on non-Windows platforms, which is what this PR does. Alternatively you could detect the OS in the
fzf_lib.lua
and add an additional branch for MacOS.